palantir / atlasdb

Transactional Distributed Database Layer
https://palantir.github.io/atlasdb/
Apache License 2.0
44 stars 7 forks source link

Improve logging for dynamic tables #7146

Closed aew9tie7Peegh6i closed 2 weeks ago

aew9tie7Peegh6i commented 3 weeks ago

General

Before this PR: Unclear from single loglines when cache misses vs. uncached reads were failing during dynamic table deletion operations

After this PR:

==COMMIT_MSG==

Priority: P1 (See internal support tickets)

Please tag any other people who should be aware of this PR: @jeremyk-91 @sverma30 @raiju

palantirtech commented 3 weeks ago

Thanks for your interest in palantir/atlasdb, @aew9tie7Peegh6i! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

changelog-app[bot] commented 3 weeks ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [ ] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

* Log when tables not found during getShortTableReferencesForExistingTables * Improve logging for "table not found" exceptions during KVS mapping failures **Check the box to generate changelog(s)** - [ ] Generate changelog entry
aew9tie7Peegh6i commented 2 weeks ago

Needs https://github.com/palantir/atlasdb/pull/7152 to merge first

aew9tie7Peegh6i commented 2 weeks ago

OBE, forks can't submit PRs that build correctly due to docker hub permissions. Closing in favour of https://github.com/palantir/atlasdb/pull/7154 now that I'm correctly set up as a github org member.