Before this PR:
Need to separate out the concept of a bucket (really, a bucket identifier, which is comprised of a bucket identifier number and a shard, and so it feels like there's a better name) and a sweepable bucket (a bucket + timestamp range)
This means I can use the bucket as a key for values (at the store interface level, we can make a more compact representation when we're storing it in the database)
After this PR:
==COMMIT_MSG==
==COMMIT_MSG==
Priority: P2
Concerns / possible downsides (what feedback would you like?):
Naming - bucket is really bucket identifier, but there's a separate bucket identifier
Is documentation needed?:
no
Development Process
Where should we start reviewing?:
Bucket
If this PR is in excess of 500 lines excluding versions lock-files, why does it not make sense to split it?:
Please tag any other people who should be aware of this PR:
@jeremyk-91
@sverma30
@raiju
General
Before this PR: Need to separate out the concept of a bucket (really, a bucket identifier, which is comprised of a bucket identifier number and a shard, and so it feels like there's a better name) and a sweepable bucket (a bucket + timestamp range)
This means I can use the bucket as a key for values (at the store interface level, we can make a more compact representation when we're storing it in the database)
After this PR:
==COMMIT_MSG== ==COMMIT_MSG==
Priority: P2
Concerns / possible downsides (what feedback would you like?): Naming - bucket is really bucket identifier, but there's a separate bucket identifier Is documentation needed?: no
Development Process
Where should we start reviewing?: Bucket If this PR is in excess of 500 lines excluding versions lock-files, why does it not make sense to split it?:
Please tag any other people who should be aware of this PR: @jeremyk-91 @sverma30 @raiju