palantir / blueprint

A React-based UI toolkit for the web
https://blueprintjs.com/
Apache License 2.0
20.63k stars 2.17k forks source link

[Table] Do we need loading states on ghost header cells? #1230

Open cmslewis opened 7 years ago

cmslewis commented 7 years ago

Bug report

Steps to reproduce

  1. Enable loading for column header cells.

Actual behavior

Ghost header cells have loading bars.

image

Expected behavior

Maybe don't have loading bars on ghost cells?

cmslewis commented 7 years ago

// CC @tgreenwatts

llorca commented 7 years ago

Why wouldn't you? Loading bars are helpful anywhere data can be loaded, which applies to both body cells and column headers. We also do it for rows because we can't know for sure the number of rows before loading

cmslewis commented 7 years ago

@llorca Ah yeah, makes sense if the table dimensions aren't known yet. I'll close.

tgreenwatts commented 7 years ago

Wait but what if we do know the number of columns already? Doesn't this example show that we know how many columns we have, so we shouldn't pretend we're going to load other columns?

llorca commented 7 years ago

You might know the number of columns while not knowing the content of those columns, in which case you'll still need a loading state

tgreenwatts commented 7 years ago

Cool clarified offline If you know the number of columns, only show loading state for the columns you know are going to load