search

palantir / blueprint

A React-based UI toolkit for the web
https://blueprintjs.com/
Apache License 2.0
20.73k stars 2.18k forks source link

Tabs2 using CDN #1332

Closed 3d0 closed 7 years ago

3d0 commented 7 years ago

Bug report

  1. Build a simple page with a buildless react (with addons)
  2. Add the CDN support of Blueprint
  3. Build a simple app with tabs2 using Javascript

    Actual behavior

the tabs are rendered , but there is no bar under the name of the selected tab. Also there is an error every time a tab is changed in the console Uncaught TypeError: this.tablistElement.queryAll is not a function at Tabs2.getTabElements...
or Uncaught TypeError: this.tablistElement.query is not a function at Tabs2.moveSelectionIndicator which makes dificult use tools like React-devtools

Expected behavior

Something like the doc?

Evidence

https://jsfiddle.net/qek4c6q8/2/

giladgray commented 7 years ago

@3d0 you're missing a dependency on dom4

3d0 commented 7 years ago

I did a test adding the dom4 library and it worked. But it should be reflected on the documentation, because is part of Blueprint.Core.

giladgray commented 7 years ago

@3d0 ah nuts i see it's missing from that big HTML example. will fix! DOM4 is mentioned elsewhere in the usage guide, and of course it's listed in package.json.