search

palantir / blueprint

A React-based UI toolkit for the web
https://blueprintjs.com/
Apache License 2.0
20.72k stars 2.18k forks source link

Half filled star icon #4337

Open ejose19 opened 4 years ago

ejose19 commented 4 years ago

Feature request

It would be nice to have a half filled star icon, to complement the current filled and empty icons, which are very used on reviews/ratings.

adidahiya commented 4 years ago

Usually we don't take external icon requests, but I will ask our designers about this one. Seems reasonable.

ejose19 commented 4 years ago

Thanks @adidahiya. Also worth noting, https://blueprintjs.com/docs/#icons on the left menu, "Icons" is already using a half filled star with the same design as the other 2, so I guess it was already made but it wasn't exported, although unfilled part doesn't have a border.

adidahiya commented 4 years ago

Ah, well those icons in the docs page are bespoke for the blueprint docs app. They're not maintained as part of the Blueprint icons set. But yes, it is fairly trivial to make the SVG for the half-filled star. I think we are open to it, just need to whip up the SVG file...

julix-unity commented 2 years ago

Just to follow up, was the half-filled star added?

Also would a rating component like https://mui.com/components/rating/ be something blueprintjs would be interested in making or is that too niche / specific?