palantir / blueprint

A React-based UI toolkit for the web
https://blueprintjs.com/
Apache License 2.0
20.73k stars 2.18k forks source link

ButtonGroup inside Label hover state styling bug #5289

Open adidahiya opened 2 years ago

adidahiya commented 2 years ago

Environment

Code Sandbox

https://codesandbox.io/s/blueprint-sandbox-forked-ge4jfc?file=/src/CoreExample.tsx

Steps to reproduce

  1. Hover over label text

Actual behavior

2022-05-09 09 53 34

First button in group styling changes to hover state. This is confusing because the first button continues to appear hovered even when a user hovers over one of the other buttons -- this makes it ambiguous what may be selected or clicked on "mousedown".

Expected behavior

No button hover styling when hovering over the label text. When hovering over one of the buttons, only that one should get hover styling.

Possible solution

adidahiya commented 2 years ago

This also applies to Label > Select > Button (and probably all Label > Button). It's confusing because clicking on the label text doesn't actually activate the button: 2022-05-09 11 49 21

adidahiya commented 2 years ago

It looks like this issue was present in Blueprint v3 too, and we haven't gotten any complaints of it yet. Therefore, i'm downgrading this to P3.