Replace array.at(-1) with array[array.length - 1]

jonaswitt commented 4 months ago

Fixes #6831

Checklist

[ ] Includes tests (n/a?)
[ ] Update documentation (n/a?)

Changes proposed in this pull request:

See #6831

Reviewers should focus on:

Testing on Safari 15.3 or earlier

Screenshot

palantirtech commented 4 months ago

Thanks for your interest in palantir/blueprint, @jonaswitt! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

changelog-app[bot] commented 4 months ago

Generate changelog in changelog-dir>`packages/core/changelog/@unreleased`</changelog-dir

What do the change types mean?

- `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._

How are new versions calculated?

- ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [ ] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Replace Array.at(-1) with .at(array.length - 1)

**Check the box to generate changelog(s)** - [ ] Generate changelog entry

jonaswitt commented 4 months ago

Not sure what to do about the CircleCI Pipeline errors, sorry. It's my first PR in this repo.

gluxon commented 4 months ago

Not sure what to do about the CircleCI Pipeline errors, sorry. It's my first PR in this repo.

I'm confused by them too actually.

Could you push another commit to see if it's still happening? The new commit can be empty:

git commit --allow-empty -m 'Empty commit to rerun CircleCI pipeline'

gluxon commented 4 months ago

Hm.. looks like the empty commit isn't working. Thanks for trying that though.

It looks like CircleCI uses your GitHub account, which surprises me. I would have expected it to have access to the repo directly. Sorry about that. Could you try the instructions here?

https://support.circleci.com/hc/en-us/articles/12504745606171-Why-am-I-seeing-the-Could-not-find-a-usable-config-yml-you-may-have-revoked-the-CircleCI-OAuth-app-message

palantir / blueprint