search

palantir / blueprint

A React-based UI toolkit for the web
https://blueprintjs.com/
Apache License 2.0
20.51k stars 2.15k forks source link

fix: prevent PanelStack2 from opening in the wrong direction #6847

Closed stropitek closed 4 days ago

stropitek commented 2 weeks ago

Fixes #6723

As additional context that was not described in the original issue, I realized that the problem only exists when using react 18, not with react 16.

I did an example of the issue in an application running with react 18 in stackblitz, one without the fix, the other with the fix. By testing the example as described in #6723, you can verify the fix.

Before the fix: https://stackblitz.com/edit/vitejs-vite-4d5jhz After the fix: https://stackblitz.com/edit/vitejs-vite-txizds

Checklist

Changes proposed in this pull request:

The changes removes one of the state that can be derived from other values directly, preventing unnecessary re-renders.

Reviewers should focus on:

Making sure the change does not break any existing behaviour.

palantirtech commented 2 weeks ago

Thanks for your interest in palantir/blueprint, @stropitek! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

stropitek commented 6 days ago

Thank you for the review @evansjohnson!

I updated the PR based on it.