palantir / blueprint

A React-based UI toolkit for the web
https://blueprintjs.com/
Apache License 2.0
20.51k stars 2.15k forks source link

Don't show slider fill before value equal to initial value #6853

Closed evansjohnson closed 1 week ago

evansjohnson commented 1 week ago

Fixes https://github.com/palantir/blueprint/issues/6844

Checklist

Changes proposed in this pull request:

I can't think of a reason a user would want the track to be filled from min to value when value === initial value, but then have value to initial value filled when value is just slightly less.

I imagine this case just wasn't explicitly considered, since often min may equal initial value and this issue is not apparent.

Reviewers should focus on:

If there's any valid use case for this track fill behavior.

Screenshot

Issue observable on slider example if showing fill for bottom example

Screenshot 2024-06-18 at 10 19 00 AM Screenshot 2024-06-18 at 10 18 57 AM Screenshot 2024-06-18 at 10 18 54 AM
svc-palantir-github commented 1 week ago

don't show slider fill before value equal to initial value

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.