Open evansjohnson opened 1 week ago
Type
Description
Build artifact links for this commit: documentation | landing | table | demo
This is an automated comment from the deploy-preview CircleCI job.
Build artifact links for this commit: documentation | landing | table | demo
This is an automated comment from the deploy-preview CircleCI job.
Build artifact links for this commit: documentation | landing | table | demo
This is an automated comment from the deploy-preview CircleCI job.
trying to figure out intent inputs before marking this ready to review
Build artifact links for this commit: documentation | landing | table | demo
This is an automated comment from the deploy-preview CircleCI job.
Build artifact links for this commit: documentation | landing | table | demo
This is an automated comment from the deploy-preview CircleCI job.
Build artifact links for this commit: documentation | landing | table | demo
This is an automated comment from the deploy-preview CircleCI job.
Build artifact links for this commit: documentation | landing | table | demo
This is an automated comment from the deploy-preview CircleCI job.
Build artifact links for this commit: documentation | landing | table | demo
This is an automated comment from the deploy-preview CircleCI job.
Build artifact links for this commit: documentation | landing | table | demo
This is an automated comment from the deploy-preview CircleCI job.
Build artifact links for this commit: documentation | landing | table | demo
This is an automated comment from the deploy-preview CircleCI job.
Intent contrast ratios against different background colors:
Color | Hex | BP color | Contrast with $white/$black at 0.752 opacity | Contrast with $light-gray-1/$dark-gray-5 at 0.752 opacity | Contrast with $white/$black at 1 opacity | Contrast with $light-gray-1/$dark-gray-5 at 1 opacity | Contrast with $light-gray-2/$dark-gray-4 at 1 opacity | Contrast with $light-gray-4 |
---|---|---|---|---|---|---|---|---|
Light primary | #2d72d2 | $blue3 | 3.06 | 2.42 | 4.72 | 3.29 | 3.55 | |
Light success | #238551 | $green3 | 3.01 | 2.36 | 4.62 | 3.22 | 3.48 | |
Light warning | #c87619 | $orange3 | 2.47 | 1.95 | 3.46 | 2.41 | 2.61 | 3 |
Light danger | #cd4246 | $red3 | 3.19 | 2.53 | 4.7 | 3.28 | 3.54 | |
Dark primary | #4c90f0 | $blue4 | 3.76 | 2.24 | 5.76 | 2.88 | 3.36 | |
Dark success | #32a467 | $green4 | 3.79 | 2.26 | 5.84 | 2.92 | 3.4 | |
Dark warning | #ec9a3c | $orange4 | 5.07 | 2.98 | 8.13 | 4.07 | 4.75 | |
Dark danger | #e76a6e | $red4 | 3.81 | 2.25 | 5.87 | 2.94 | 3.43 |
Build artifact links for this commit: documentation | landing | table | demo
This is an automated comment from the deploy-preview CircleCI job.
Build artifact links for this commit: documentation | landing | table | demo
This is an automated comment from the deploy-preview CircleCI job.
Compare public docs vs latest "documentation" link from latest @svc-palantir-github comment
Design review checklist:
Checkbox
, Radio
, Switch
Button
, Menu
, Tabs
InputGroup
, NumericInput
, EditableText
intent
Checkbox
, Radio
, Switch
Button
, Menu
, Tabs
InputGroup
, NumericInput
, EditableText
intent
Fixes no issue
Checklist
Changes proposed in this pull request:
Update color of focus outline to meet 3:1 contrast standard for UI component focus states
https://webaim.org/resources/contrastchecker/
Reviewers should focus on:
$white
/$black
?WCAG Guidelines
From what I can tell, WCAG did not require minimum contrast in 2.1, but in 2.2 has a section on focus appearance which specifies the 3:1 minimum ratio
Screenshot
Current:
This PR: