Fix end time selection before selecting date

evansjohnson commented 1 week ago

Fixes https://github.com/palantir/blueprint/issues/6863

Fixes https://github.com/palantir/blueprint/issues/6856

Previously, users could end up with a reversed selection range if modifying the time input of the end date before selecting a date. Today's date was used as the default in these cases, leaving the user with a reversed range if the start date was later than today's date.

Checklist

[x] Includes tests
[-] Update documentation

Changes proposed in this pull request:

Fix behavior of default date such that selected range cannot end up reversed.
When allowSingleDayRange is not true, ensure the default date is 1 day off from the already selected date (otherwise keep today's date as default if no dates are selected).

Reviewers should focus on:

There's a slight behavior break in that users could previously select a single day range by modifying the time with today's date selected as the start date. This seems like a bug that's okay to fix but would like a second opinion on this.
Any better solutions than to add/subtract a day from the default when allowSingleDayRange is not true?
Would you prefer to see the allowSingleDayRange change split out?

changelog-app[bot] commented 1 week ago

Generate changelog in changelog-dir>`packages/datetime2/changelog/@unreleased`</changelog-dir

What do the change types mean?

- `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._

How are new versions calculated?

- ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [ ] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Fix end time selection before selecting date

**Check the box to generate changelog(s)** - [ ] Generate changelog entry