Add affordance to icon selector in docs and fix selection state

evansjohnson commented 3 months ago

Add better affordance that something needs to be typed for icons to show. I thought the docs were broken and didn't initially try typing anything here.
Fix selection/active state. https://github.com/palantir/blueprint/commit/f0a9b09f715cfcc36ba237dcbcd4c1c90dfd21f2#diff-8194812817b7f429b5320bb9be65c267dea2308f9a5b914411859fc8d61d18b0R222 seems to be a breaking change (see how some other docs examples were updated). Maybe this was only part of the initial BP 5 release, but didn't seem to be mentioned in the upgrade guide. In any case this has been out long enough that it should be considered expected behavior at this point
Update docs to mention selected only applies with the "listoption" role - I had to dig into the code to figure out what was going wrong here and initially thought selection state was entirely broken.

Current: I found this to be confusing - this looks like it came up in the PR that introduced but it was a big one and I suppose was never addressed Screenshot 2024-06-27 at 3 01 48 PM no indication of selection within menu - note selected icon shown in button:

This PR: custom placeholder text: Screenshot 2024-06-27 at 3 02 10 PM selection state:

svc-palantir-github commented 3 months ago

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

evansjohnson commented 3 months ago

Noticed https://github.com/palantir/blueprint/issues/6878 while testing but don't want to put more time into this for now

svc-palantir-github commented 3 months ago

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

svc-palantir-github commented 3 months ago

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

palantir / blueprint