Open filipbalucha opened 3 days ago
Thanks for your interest in palantir/blueprint, @filipbalucha! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.
Type
Description
Fixes #1609
Checklist
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot
Before:
https://github.com/palantir/blueprint/assets/40673216/fef9d318-f6da-46d2-9032-d0248940d2fe
After:
https://github.com/palantir/blueprint/assets/40673216/322ce3ec-afee-4abe-8839-3f9db9b13318
Not addressed in this PR
Polishing interactions with frozen cells. The scrollable part of the table should only scroll if the frozen cell would otherwise not be visible. This is not a regression caused by this PR; rather, it is a logical next step.
https://github.com/palantir/blueprint/assets/40673216/1a637d89-9d2a-4f01-b509-fae83533a3d4
getColumnIndicesInRect
operates on viewport rect but does not ignore headers or take frozen cells into account; this might be feeding into https://github.com/palantir/blueprint/issues/4780 and potentially contaminating the response ofonVisibleCellsChange
. Again, this is a side observation rather than a regression.