palantir / blueprint

A React-based UI toolkit for the web
https://blueprintjs.com/
Apache License 2.0
20.74k stars 2.18k forks source link

Some tests failing when running `yarn verify` #6926

Open evansjohnson opened 3 months ago

evansjohnson commented 3 months ago

Environment

Steps to reproduce

Follow README.md setup steps up until yarn verify

Actual behavior

The following errors: Screenshot 2024-07-25 at 1 41 40 PM Screenshot 2024-07-25 at 1 41 24 PM

Expected behavior

the tests should not error locally but seemingly pass running in CI (TODO: confirm these tests actually are running in CI)

Possible solution

Wondering if all scroll related tests are related to running this on a macbook where the default is to hide scrollbars unless scrolling. I did try changing this operating system setting but saw the same failures (though perhaps a restart would be needed for the changes to take effect here, or I hit some test cache)

evansjohnson commented 3 months ago

If https://github.com/palantir/blueprint/pull/6925/files merges make sure readme is re-updated if this is addressed

ggdouglas commented 3 months ago

@evansjohnson I also encountered the error in cssVariables.test.ts (but not the scrollbar issues unfortunately). Decided to dig in a bit and was able to get the test to pass with #6934. This doesn't necessarily address the underlying issue, but it does make the devx a bit better for newcomers (like myself)

ggdouglas commented 3 months ago

Reopening since #6934 doesn't address the whole issue (scroll test flake)