delete_after_merge being ignored

[kevinohara80]

I'm not sure what we're doing wrong here. The branches are being merged but the delete_after_merge flag is being ignored and the branches aren't being deleted. I also can't see anything in the logs that mention deletion of the branch.

Here's the project .bulldozer.yml

version: 1

merge:
  whitelist:
    branches: ["develop", "master"]
  blacklist:
    labels: ["no merge"]
    comment_substrings: ["==DO_NOT_MERGE=="]
  method: squash
  branch_method:
    develop: squash
    master: merge
  options:
    squash:
      title: "pull_request_title"
      body: "pull_request_body"
      message_delimiter: ==COMMIT_MSG==
  delete_after_merge: true

update:
  whitelist:
    branches: ["develop", "master"]
  blacklist:
    labels: ["no update"]

[bluekeyes]

That's strange. The config looks correct to me and from the deletion code, the only case where nothing is logged is if the option is not enabled. The other cases where deletion will not happen are:

• The pull request is from a fork
• There are other open PRs that are targeting the branch to delete
• The branch protection settings or other permissions prevent deleting the branch

Something should be logged in all of those cases, including that deletion was attempted even if the API call then fails for some reason.

Would it possible to share the log output for a full evaluation that merged a PR?

[kevinohara80]

Yeah, I'll try to get the full output. None of the situations you mentioned apply here.

[kevinohara80]

Here's an output of the logs...

https://docs.google.com/spreadsheets/d/1c2w_OEzYKp2hyXmqGRXU4TG5NHlvl0ow15iEnhkh_1w/edit?usp=sharing

[kevinohara80]

One more thing to note...I'm using the current snapshot docker image

[bluekeyes]

I just published a new snapshot image that has the additional logging you proposed in #113 along with some changes to the configuration loading logs. Hopefully that will reveal something helpful here.