A product I maintain recently had a bug where we instantiated a conjure object in Java source and then did nothing with it. ErrorProne has a @CheckReturnValue pattern meant to help with this. Let's apply it and try to squash this category of bug entirely.
What did you want to happen?
Add @CheckReturnValue to the generated MyObject.builder() and MyObject.Builder.build() methods. When paired with the error prone rule, this will catch any issues where callers call one of those methods but then discard the result. This will manifest as a build failure when they pick up the new version of conjure-java.
What happened?
A product I maintain recently had a bug where we instantiated a conjure object in Java source and then did nothing with it. ErrorProne has a @CheckReturnValue pattern meant to help with this. Let's apply it and try to squash this category of bug entirely.
What did you want to happen?
Add
@CheckReturnValueto the generatedMyObject.builder()andMyObject.Builder.build()methods. When paired with the error prone rule, this will catch any issues where callers call one of those methods but then discard the result. This will manifest as a build failure when they pick up the new version of conjure-java.