changelog-app[bot]
commented
2 months ago Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir
What do the change types mean?
- `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._How are new versions calculated?
- ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.Type
Description
bjlaub
autorelease3[bot]
There's a common pattern where folks use a try-with-resources block on the response stream. While it's generally good practice to close our resources, the webserver is responsible for this one, and closing it in a finally block can prevent us from relaying errors to clients! By blocking close calls to the delegate, we can allow folks to close all the things, while providing accurate failure information to clients :-]
==COMMIT_MSG== conjure-undertow streamed binary response bodies protect against early closure ==COMMIT_MSG==