palantir / conjure-java

Conjure generator for Java clients and servers
Apache License 2.0
27 stars 43 forks source link

add support for triggering callback after auth token has been set #2362

Closed bjlaub closed 2 months ago

bjlaub commented 2 months ago

Before this PR

Runtime will try to parse and inject an auth token, but provides no mechanism for consumers to apply any extra business logic based on the token value before a handler is actually invoked.

After this PR

add support for triggering callback after auth token has been set

This allows consumers to hook into the AuthorizationExtractor encapsulated by ConjureUndertowRuntime and make early decisions about request processing based on the extracted token.

The expected use case is to be able to e.g. implement rate limiting or other business logic using data within a JWT that can be done without any extra validation, but should happen just before actual request handlers are invoked.

==COMMIT_MSG== add support for triggering callback after auth token has been set ==COMMIT_MSG==

Possible downsides?

changelog-app[bot] commented 2 months ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [ ] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

add support for triggering callback after auth token has been set **Check the box to generate changelog(s)** - [ ] Generate changelog entry
autorelease3[bot] commented 2 months ago

Released 8.28.0

carterkozak commented 2 months ago

wat -- changelog isn't enforced in this repo!? I think the automation has messed the config up a bit