search

palantir / conjure-python-client

Python client and JSON encoders for use with generated Conjure clients
Apache License 2.0
7 stars 20 forks source link

Dependency on enum34 breaks python 3.7 (and proabably 3.6) - is it possible to make it a conditional dependency #100

Closed Ancient87 closed 2 years ago

Ancient87 commented 3 years ago

What happened?

I was trying to integrate the conjure generated python classes into my Python3.7.5 environment, and hit an issue. It seem that enum34 breaks newer versions of setuptools as discussed in detail here and here. As both conjure-python-client and the generated classes themselves list enum34 as a dependency Installing the package into my project breaks pip.

For now I had to end up manually scripting/editing the dependency in my generated class files, and "vendor" "conjure-python-client" which is clearly not ideal.

What did you want to happen?

Perhaps it would be an easy fix to replace the dependency with a conditional such as '"enum34; python_version < "3.4"'

Many thanks

Latios96 commented 3 years ago

Hi,

I have the same issue as you describe.

There is a pull request here fixing this issue, but it was not merged yet. Would it be possible to merge this pull request? Is there something missing that prevents merging this?

robert3005 commented 2 years ago

Fixed in 2.x (there's also conjure-python 4.x that uses it)