palantir / conjure-python-client

Python client and JSON encoders for use with generated Conjure clients
Apache License 2.0
7 stars 20 forks source link

Arubin/allow passing proxies #102

Closed AaronJRubin closed 3 years ago

AaronJRubin commented 3 years ago

Before this PR

It was not possible to specify proxy settings (other than relying upon system defaults, which are not always sufficient, especially for proxies that require authentication).

After this PR

It is possible to specify proxy settings, following the standard Requests conventions.

Possible downsides?

None.

changelog-app[bot] commented 3 years ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

Type

- [ ] Feature - [X] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Arubin/allow passing proxies ## Before this PR It was not possible to specify proxy settings (other than relying upon system defaults, which are not always sufficient, especially for proxies that require authentication). ## After this PR It is possible to specify proxy settings, following the standard Requests conventions. ## Possible downsides? None. **Check the box to generate changelog(s)** - [ ] Generate changelog entry
stale[bot] commented 3 years ago

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.