palantir / conjure-python-client

Python client and JSON encoders for use with generated Conjure clients
Apache License 2.0
7 stars 20 forks source link

Fix version issue and make TransportAdapter state backwards compatible #164

Closed BenjaminLowry closed 2 weeks ago

BenjaminLowry commented 2 weeks ago

Before this PR

After this PR

conda feedstock tries to run git to get the version during conda build because I removed the logic that checks if _version.py already exists, which is does in that case, and we don't want this logic run at that point.

Also, some users of this lib have stored pickles of the old version of TransportAdapter and then when unpickling against this new version the _enable_keep_alive field is missing so changing state such that we can handle said case even though it's an odd workflow. ==COMMIT_MSG== ==COMMIT_MSG==

Possible downsides?

changelog-app[bot] commented 2 weeks ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - πŸ› The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [ ] Improvement - [x] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Fix version issues with conda feedstock **Check the box to generate changelog(s)** - [x] Generate changelog entry
johnhany97 commented 2 weeks ago

πŸ‘

johnhany97 commented 2 weeks ago

πŸ‘

autorelease3[bot] commented 2 weeks ago

Released 2.11.0