search

palantir / conjure-python-client

Python client and JSON encoders for use with generated Conjure clients
Apache License 2.0
7 stars 20 forks source link

Improvement: Don't overwrite trace ID if it's present in the headers … #165

Open psyclaudeZ opened 1 week ago

psyclaudeZ commented 1 week ago

…passed in

Before this PR

It overwrites the trace ID regardless.

After this PR

Ultimately, service users will be able to utilize their trace IDs at hand when sending the requests.

Alternatively, I could apply what I did internally with python-client-<codename_pltr_sso> by making it import the tracing library. But consider this is a public facing repo + hesitation of open sourcing the tracing lib + comparatively less cognitive load put to the user, I personally this this is a reasonable approach for now.

==COMMIT_MSG== ==COMMIT_MSG==

Possible downsides?

palantirtech commented 1 week ago

Thanks for your interest in palantir/conjure-python-client, @psyclaudeZ! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.