Closed cdb39 closed 4 years ago
Type
Description
Not entirely sure why environment markers are not being parsed by tox / setup.py, even if using the later versions.
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.
Hi,
installing enum34 in Python versions later than Python 3.4 causes some serious problems because it shadows the module from stdlib. Right now, you need to make some workarounds when installing conjure-python-client to avoid installing enum34. That's a really bad experience. Any chances to get this PR merged?
enum34
backports the enum functionality delivered in python 3.4 to older versions of python. Limit it's installation to only those earlier versions.Similarly
typing
became part of the stdlib in 3.5. Restrict its installation to only earlier python versions.In both instances, without this restriction, the installed packages overshadow stdlib modules, resulting in undesired behaviour (such as the disappearence of newer features).
Before this PR
enum34
andtyping
are installed regardless of python version, potentially overshadowing the stdlib.After this PR
Those dependencies are only installed when needed. ==COMMIT_MSG== ==COMMIT_MSG==
Possible downsides?