search

palantir / conjure-python

Conjure generator for Python clients
Apache License 2.0
19 stars 18 forks source link

Encode path parameters in endpoint definitions #597

Closed ktekelioglu closed 1 week ago

ktekelioglu commented 2 years ago

Before this PR

Fixes https://github.com/palantir/conjure-python/issues/595

After this PR

==COMMIT_MSG== Path parameters are url encoded per conjure specification ==COMMIT_MSG==

Possible downsides?

changelog-app[bot] commented 2 years ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

Type See change types. Select one:

- [ ] Feature - [ ] Improvement - [x] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Path parameters are url encoded per conjure specification **Check the box to generate changelog(s)** - [x] Generate changelog entry
BenjaminLowry commented 1 week ago

Addressed in https://github.com/palantir/conjure-python/pull/927