Don't panic on invalid user agent versions - Githubissues

palantir / conjure-rust-runtime

Rust implementation of the Conjure runtime

10 stars 7 forks source link

Don't panic on invalid user agent versions #132

Closed sfackler closed 2 years ago

sfackler commented 2 years ago

Before this PR

An invalid product version in a Witchcraft server (e.g. one generated with a .dirty suffix would cause the server to panic on startup.

After this PR

==COMMIT_MSG== Invalid user agent versions are now replaced with 0.0.0 rather than panicking. ==COMMIT_MSG==

This matches conjure-java-runtime's behavior: https://github.com/palantir/conjure-java-runtime-api/blob/develop/service-config/src/main/java/com/palantir/conjure/java/api/config/service/UserAgent.java#L101.

Possible downsides?

changelog-app[bot] commented 2 years ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

Type

- [ ] Feature - [x] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Invalid user agent versions are now replaced with `0.0.0` rather than panicking.

**Check the box to generate changelog(s)** - [x] Generate changelog entry