palantir / conjure-rust-runtime

Rust implementation of the Conjure runtime
10 stars 7 forks source link

Update retry backoff scale to be consistent with conjure-java-runtime #162

Closed jonsyu1 closed 1 year ago

jonsyu1 commented 1 year ago

See https://github.com/palantir/dialogue/blob/3.90.0/dialogue-core/src/main/java/com/palantir/dialogue/core/RetryingChannel.java#L372-L378

changelog-app[bot] commented 1 year ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [x] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Update retry backoff scale to be consistent with conjure-java-runtime **Check the box to generate changelog(s)** - [x] Generate changelog entry
sfackler commented 1 year ago

Ah nice catch.

Looks like the build's failing with a deprecated method call though.

jonsyu1 commented 1 year ago

(still waiting on building gnuplot so I can update the simulations plot)

sfackler commented 1 year ago

I just install it via homebrew.

sfackler commented 1 year ago

Also wondering if the simulation stuff is even worth having anymore. We haven't done significant work on client side node selection in quite a while, either here or in Dialogue.

jonsyu1 commented 1 year ago

I just install it via homebrew.

Yup, homebrew took over 30 minutes so I went to lunch while it ran.

Also wondering if the simulation stuff is even worth having anymore. We haven't done significant work on client side node selection in quite a while, either here or in Dialogue.

It's trivial to bring it back at a later point when we need it again, so I suggest we remove it in a separate PR.

jonsyu1 commented 1 year ago

My simulations panicked locally:

thread 'main' panicked at 'attempt to add with overflow', /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/iter/traits/accum.rs:149:1

I'll dig more into this when I have time. Or I'll rebase this on top of a PR removing simulations.

sfackler commented 1 year ago

https://github.com/palantir/conjure-rust-runtime/pull/163

jonsyu1 commented 1 year ago

Perfect, thank you. I'll go ahead and rebase