search

palantir / conjure-rust

Conjure support for Rust
Apache License 2.0
20 stars 11 forks source link

Support per-endpoint request size limits #380

Closed sfackler closed 1 month ago

sfackler commented 1 month ago

Before this PR

All endpoints with serializable request bodies limited them to 50MiB without the ability to configure that.

After this PR

==COMMIT_MSG== Added support for per-endpoint request size limits via the server-limit-request-size: N tag. ==COMMIT_MSG==

There's a bit of jank in the codegen since up until now it's been totally infallible. To work around this, we inject compile_error! macro calls when the configured limit fails to parse properly. In the Java implementation, this parsing is deferred to runtime.

The limit is passed as a const generic parameter in the StdRequestDeserializer. I'm not sure if this is the "right" approach, but it lets us preserve back compat. Custom endpoints can set the parameter directly, which is workable but a bit weird. In the future it might make sense for the limit to be a more first-class concept in some way.

Closes #374

changelog-app[bot] commented 1 month ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [x] Feature - [ ] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Added support for per-endpoint request size limits via the `server-limit-request-size: N` tag. **Check the box to generate changelog(s)** - [x] Generate changelog entry