Fix isConjureError for nullish values and add tests

palantir / conjure-typescript-runtime

An HTTP bridge library for use in front end applications and generated conjure code

Apache License 2.0

5 stars 13 forks source link

Closed tomshen closed 2 years ago

tomshen commented 2 years ago

isConjureError(null) and isConjureError(undefined) would throw type errors:

TypeError: Cannot read property '__proto__' of null

I refactored isConjureError to handle unknown inputs rather than just any.
I added tests

==COMMIT_MSG== Fix isConjureError handling of null/undefined values. ==COMMIT_MSG==

N/A

gluxon commented 2 years ago