search

palantir / conjure-verification

A testing tool that ensures all Conjure clients and servers adhere to a common wire spec
Apache License 2.0
9 stars 6 forks source link

Upgrade Xcode version to 12.5.0 #506

Closed bluekeyes closed 3 years ago

bluekeyes commented 3 years ago

Before this PR

The project uses a soon-to-be-deprecated version of Xcode. We need to move to a newer version before CircleCI removes support for the old image.

After this PR

==COMMIT_MSG== Upgrade Xcode version to 12.5.0 ==COMMIT_MSG==

Possible downsides?

The new version could require additional changes to the build process.

changelog-app[bot] commented 3 years ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

Type

- [ ] Feature - [X] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Upgrade Xcode version to 12.5.0 **Check the box to generate changelog(s)** - [x] Generate changelog entry
bluekeyes commented 3 years ago

The Gradle failure appears to be some kind of deadlock with parallel builds. I can reproduce it locally as well, but running with --no-parallel fixes the problem.

stale[bot] commented 3 years ago

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.