palantir / conjure-verification

A testing tool that ensures all Conjure clients and servers adhere to a common wire spec
Apache License 2.0
9 stars 6 forks source link

Add support for aarch64 #522

Closed mglazer closed 1 year ago

mglazer commented 2 years ago

Before this PR

After this PR

==COMMIT_MSG== Add support for aarch64

This causes a breaking change for any direct consumers as the coordinates for the osx bundle will be changing such that there is now a:

osx-x86_64 package

and

osx-aarch64 package

This adds a bit more safety to ensure that consumers don't inadvertently grab the incorrect package.

Also bump the rust version to 1.63.0 which is the latest version, just for good measure. ==COMMIT_MSG==

Possible downsides?

changelog-app[bot] commented 2 years ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

Type See change types. Select one:

- [ ] Feature - [x] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Add support for aarch64 This causes a breaking change for any direct consumers as the coordinates for the osx bundle will be changing such that there is now a: osx-x86_64 package and osx-aarch64 package This adds a bit more safety to ensure that consumers don't inadvertently grab the incorrect package. Also bump the rust version to 1.54.0. Versions prior to 1.49.0 do not have support for aarch64. I arbitrarily picked 1.54.0 even though 1.63.0 was just published since I didn't want to go too bleeding edge. **Check the box to generate changelog(s)** - [x] Generate changelog entry
xRuiAlves commented 1 year ago

Hi friends! Do you think you could remove me as reviewer from this one? Don't have the permission to do so :D (cc @carterkozak )

mglazer commented 1 year ago

This is pretty beyond repair, I spent way too much time trying to fix it, rust diverged too much from when this repo was originally crafted.