search

palantir / dialogue

A client-side RPC library for conjure-java
Apache License 2.0
29 stars 14 forks source link

feature: add support for HeaderMap #2281

Closed Jiahui-Zhang-20 closed 3 months ago

Jiahui-Zhang-20 commented 4 months ago

Before this PR

Dialogue annotations do not support including headers dynamically to a request. This prevents the client from setting headers (e.g. auth headers) during runtime. The Dialogue client cannot accommodate custom auth header schemes unbeknownst at compile time.

After this PR

We implement a Request.HeaderMap annotation that can decode a MultiMap<String, String> where the map key is the header key and the map value is the corresponding header value.

==COMMIT_MSG==

feature: add support for HeaderMap ==COMMIT_MSG==

palantirtech commented 4 months ago

Thanks for your interest in palantir/dialogue, @Jiahui-Zhang-20! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

svc-autorelease commented 3 months ago

Released 3.135.0