palantir / dialogue

A client-side RPC library for conjure-java
Apache License 2.0
29 stars 14 forks source link

Remove client request size metric channel to reduce dialogue metric load #2300

Closed carterkozak closed 3 months ago

carterkozak commented 3 months ago

This reverts commit 50b0bfd9bf5f65029adb71dbf91516c33f9be527 (#2023)

Before this PR

See #2023

After this PR

I believe we're done with the analysis that this feature was built for. per-endpoint metrics may end up with very high cardinality, and put load on the metric timeseries infrastructure.

==COMMIT_MSG== Remove client request size metric channel to reduce dialogue metric load ==COMMIT_MSG==

Possible downsides?

Less insight into large requests and whether or not they're repeatable.

changelog-app[bot] commented 3 months ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [x] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Remove client request size metric channel to reduce dialogue metric load **Check the box to generate changelog(s)** - [x] Generate changelog entry
svc-autorelease commented 3 months ago

Released 3.137.0