search

palantir / docker-compose-rule

A JUnit rule to manage docker containers using docker-compose
Apache License 2.0
425 stars 90 forks source link

match port range output from docker ps #695

Closed hughsimpson closed 2 years ago

hughsimpson commented 2 years ago

Before this PR

Port ranges from docker ps output weren't mapped

After this PR

==COMMIT_MSG== Map port range mappings from docker ps output ==COMMIT_MSG==

Fixes https://github.com/palantir/docker-compose-rule/issues/689

Possible downsides?

palantirtech commented 2 years ago

Thanks for your interest in palantir/docker-compose-rule, @hughsimpson! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

changelog-app[bot] commented 2 years ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

Type

- [ ] Feature - [ ] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

match port range output from docker ps ## Before this PR Port ranges weren't mapped (cf https://github.com/palantir/docker-compose-rule/issues/689) ## After this PR This fixes that ## Possible downsides? Can't think of any **Check the box to generate changelog(s)** - [ ] Generate changelog entry
hughsimpson commented 2 years ago

Hey @fawind I think this may need a kick? Bot seems stuck on the last requirement, probably because GitHub got sad around that time. Any chance you can help out?

fawind commented 2 years ago

Ah, I pushed a commit which invalidated my approval and stopped bots from merging this!

svc-autorelease commented 2 years ago

Released 1.8.0