palantir / docker-compose-rule

A JUnit rule to manage docker containers using docker-compose
Apache License 2.0
425 stars 90 forks source link

Fix parsing of docker-compose < 1.25.2 output on narrow terminals #721

Open albanf opened 1 year ago

albanf commented 1 year ago

Before this PR

Issue described https://github.com/palantir/docker-compose-rule/issues/411

Fixed for docker-machine in https://github.com/palantir/docker-compose-rule/pull/424, but it's easy to forget to set the COLUMNS in other contexts.

We cannot upgrade to docker-compose 1.25.2+ for various reasons, so this workaround is useful.

After this PR

==COMMIT_MSG== Works around ps output of docker-compose before 1.25.2 which adjust their output based on the width of the terminal. ==COMMIT_MSG==

Possible downsides?

palantirtech commented 1 year ago

Thanks for your interest in palantir/docker-compose-rule, @albanf! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

changelog-app[bot] commented 1 year ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

Type

- [ ] Feature - [ ] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Works around ps output of docker-compose before 1.25.2 which adjust their output based on the width of the terminal. **Check the box to generate changelog(s)** - [ ] Generate changelog entry