search

palantir / docker-compose-rule

A JUnit rule to manage docker containers using docker-compose
Apache License 2.0
425 stars 90 forks source link

Remove project name validation #741

Closed pkoenig10 closed 7 months ago

pkoenig10 commented 7 months ago

The project name validation no longer matches the Docker Compose behaivor.

https://github.com/docker/compose/pull/5788

Docker Compose will normalize project names if they do not conform to it's requirements.

This is better for consumers because it means they can use the same project names in tests and when running Docker Compose manually.

changelog-app[bot] commented 7 months ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [X] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Project names are no longer validation. Any value can be used for a project name. **Check the box to generate changelog(s)** - [X] Generate changelog entry
pkoenig10 commented 7 months ago

I know this project is old. But we still use it in some legacy tests internally and relaxing this validation would be help us out.

svc-autorelease commented 7 months ago

Released 2.2.0