search

palantir / eclipse-typescript

An Eclipse plug-in for developing in the TypeScript language.
Apache License 2.0
339 stars 73 forks source link

Bump ts to 2.1 #339

Closed sixinli closed 7 years ago

sixinli commented 7 years ago

fixed a few more things after https://github.com/palantir/eclipse-typescript/pull/337

@Rouche @mzmaryzhuang

Rouche commented 7 years ago

Cool @sixinli Did you merged my fork? If no, this commit end up almost identical lol.

I had a few more fixes, #337 changed the updateTypeScript.sh case of directory, i did the same because the directory in the first line (cd ..\TypeScript) is cased.

For the doc, dont you need -g option? npm install -g dos2unix jake

I also wanted to bump Tycko to latest version (0.26) so the reference in the project can be JavaSE_1.8.

And of course double verify compiler options.

sixinli commented 7 years ago

ah cool, I ended up making the same change while trying to get it to build locally :)

I can update the Typescript casing, do you mind opening a separate PR for updating Tycko @Rouche ? I will update the docs PR too

Rouche commented 7 years ago

This also fixes #331 #328

Rouche commented 7 years ago

@sixinli Hi, did you get my mail about the casing? (TypeScript) is the name of the Git repository by default. (https://github.com/Microsoft/TypeScript) for the commandline to work,

Also, I just updated Tycho to 0.26.0 and changed the Eclipse repository to use Mars instead of Kepler.

Problem is it will have conflicts with your commit. I will have to wait for yours to be merged because i need to remove .qualifier from versions in pom.xml due to changes in Tycho validations.

Its in my fork.

sixinli commented 7 years ago

oops my bad on misreading the casing, changing it now

sixinli commented 7 years ago

@Rouche looks good? will merge if so :)

Rouche commented 7 years ago

@sixinli Yep! 👍

sixinli commented 7 years ago

@Rouche the publish task has some problem, we are fixing it atm. You might need to build it locally for now :( sorry

Rouche commented 7 years ago

Yeah no problem.

Will re-fork and PR the Tycho update later this week.

david-bouyssie commented 7 years ago

BUILD SUCCESS only if I use the following command line: mvn -DforceContextQualifier=true package

Otherwise I get the error: [ERROR] Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:0.18.1:build-qualifier (default-build-qualifier) on project com.palantir.typescript: Execution default-build-qualifier of goal org.eclipse.tycho:tycho-packaging-plugin:0.18.1:build-qualifier failed: One of setGitDir or setWorkTree must be called.

Rouche commented 7 years ago

Maven version maybe? Runnin in parent dir? Option in settings.xml? Just ideas, hard to tell when travis build is ok and mine too.

david-bouyssie commented 7 years ago

My maven version is 3.3.3 However my "settings.xml" file is configured to target an artifactory, so it may explain the problem.