palantir / eclipse-typescript

An Eclipse plug-in for developing in the TypeScript language.
Apache License 2.0
339 stars 73 forks source link

NullPointerException PresentationReconciler.getDamagedRegion(PresentationReconciler.java:132) #357

Open ahansen1 opened 7 years ago

ahansen1 commented 7 years ago

As described in this comment on the plugin page a NullPointerException is thrown on the PresentationReconciler.getDamagedRegion when attempting to do a compare of a TypesScript file with this plugin installed.

It appears that @Rouche comitted a fix on his fork back in January. Not sure if it works? But looked promising. https://github.com/Rouche/eclipse-typescript/commit/beac08a306aba3d7815a975f9bbcb1ee01e39f38

Rouche commented 7 years ago

If you want a working version updated with TypeScript 2.5.3, you have to build on my Fork.

Working perfectly under Oxygen. You need JDK 8.

ahansen1 commented 7 years ago

@Rouche thanks! I actually tried building it this morning, but unfortunately the proxy I'm behind blocks some of the downloads from the maven package. Would be nice to get a working version published onto an update site we could just point to from eclipse. I just found a different Eclipse Typescript plugin that seems to be working non Neon that I'll use in the meantime.

Rouche commented 7 years ago

com.palantir.typescript.p2updatesite-2.5.3.zip