palantir / gerrit-ci

Plugin for Gerrit enabling self-service continuous integration workflows with Jenkins.
Apache License 2.0
18 stars 9 forks source link

make jobparser safe against NPE when looking for nonexistent setting … #11

Closed camushoilingma closed 9 years ago

camushoilingma commented 9 years ago

If a element is not found, we return null anyway. Therefore, there's no reason not to catch the NPE and return null. This eliminates some of the ugly 500 errors when the page loads.