Typing '/' in command fields switches focus to search box

palantir / gerrit-ci

Plugin for Gerrit enabling self-service continuous integration workflows with Jenkins.

Apache License 2.0

18 stars 9 forks source link

Typing '/' in command fields switches focus to search box #19

Open bluekeyes opened 8 years ago

bluekeyes commented 8 years ago

When editing commands, typing '/' triggers the Gerrit keyboard shortcut for search and switches focus to the search box. This makes it hard to entry commands like ./scripts/publish.sh, forcing you to use copy and paste. There's probably some option that we need to set on text fields to disable shortcut handling.

Tested the master branch with Chrome and Firefox on Linux and reproduced the issue in both browsers.

mass commented 8 years ago

I noticed that bug as I was working on Gerrit-CI, and I thought that I fixed it with this commit: https://github.com/palantir/gerrit-ci/commit/1e695ddba2887b1a0c14789c37dd37e74ff63344 (I admit, the commit message was unclear).

Although, if you are experiencing the issue again, it must be that something else has caused the issue to re-appear. Could it be that there is a new text field that was added that didn't have the KeyPressHandler added to it?