search

palantir / gerrit-ci

Plugin for Gerrit enabling self-service continuous integration workflows with Jenkins.
Apache License 2.0
18 stars 9 forks source link

Newren/more thorough cleanup #6

Closed newren closed 9 years ago

newren commented 9 years ago

I should probably also do the cleanup suggested in the final commit message. But, it's late, this isn't a regression, and this stuff is in a reviewable state even if we decide more should be done before merging.

mass commented 9 years ago

I agree completely with your assessment in the second commit message. I hadn't really considered this when I was originally designing the JenkinsJobParser. We could have some sort of tag indicating the transition, like ### END PREBUILD COMMANDS ### or maybe something more creative and punny. Then, when parsing the XML, we can simply throw out everything before this tag and keep the rest as the user's command.

camushoilingma commented 9 years ago

Tested this locally to make sure the regex worked. Seems good to me :)