palantir / gerrit-ci

Plugin for Gerrit enabling self-service continuous integration workflows with Jenkins.
Apache License 2.0
18 stars 9 forks source link

replace & and > < symbols before they are written to xml config files #8

Closed camushoilingma closed 9 years ago

newren commented 9 years ago

It hadn't even occurred to me that we'd need to protect the branch regex, or the project name, or any of that other stuff. Makes sense to just be cautious, though. And seems to work like a charm with a simple './scripts/verify.sh && echo worked', at least once I realized I needed to click on the 'Save' button on the global configuration before I could load the per-repository gerrit-ci settings. Do we have that tidbit in the admin/development/whatever guide?