search

palantir / go-java-launcher

A simple Go program for launching Java programs from a fixed configuration. This program replaces Gradle-generated Bash launch scripts which are susceptible to attacks via injection of environment variables of the form JAVA_OPTS='$(rm -rf /)'.
Apache License 2.0
67 stars 27 forks source link

Enable active processor count overriding by default #329

Closed andybradshaw closed 1 year ago

andybradshaw commented 1 year ago

Before this PR

After this PR

==COMMIT_MSG== Enable active processor count overriding by default ==COMMIT_MSG==

Possible downsides?

changelog-app[bot] commented 1 year ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

Type

- [x] Feature - [ ] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Enable active processor count overriding by default **Check the box to generate changelog(s)** - [x] Generate changelog entry
andybradshaw commented 1 year ago

I want to double checking something real quick on a place where this is deployed... for some reason I remember seeing a higher number of processors the last time I looked at integration tests for this. just want to make sure we're not doing something silly and always returning 2 here 🙃

andybradshaw commented 1 year ago

Confirmed internally that a larger number of cpu shares does lead to the "right" active processor arg getting set