search

palantir / go-java-launcher

A simple Go program for launching Java programs from a fixed configuration. This program replaces Gradle-generated Bash launch scripts which are susceptible to attacks via injection of environment variables of the form JAVA_OPTS='$(rm -rf /)'.
Apache License 2.0
67 stars 27 forks source link

Remove the experimental `ContainerV2` flag #466

Closed mpritham closed 5 days ago

mpritham commented 5 days ago

Before this PR

In #369, we enabled the use of the logic behind the containersV2 flag by default. Internally, there are no usages of containerV2: false. We can remove the flag, and the fallback behavior now.

After this PR

==COMMIT_MSG== Remove the experimental ContainerV2 flag ==COMMIT_MSG==

Possible downsides?

changelog-app[bot] commented 5 days ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [x] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Remove the experimental `ContainerV2` flag **Check the box to generate changelog(s)** - [x] Generate changelog entry