A project internally was running out of heap in CI. We did a JFR and determined that JarFile and the sheer number of InflaterInputStreams it creates was using up gigabytes of space. DataInputStream was also allocating a lot (it allocates 240+ bytes the moment you create it).
After this PR
Use JarInputStream instead, which does not appear to have the same issue.
==COMMIT_MSG==
Reduce memory usage of checkClasspathCompatible
==COMMIT_MSG==
What do the change types mean?
- `feature`: A new feature of the service.
- `improvement`: An incremental improvement in the functionality or operation of the service.
- `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
- `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
- `deprecation`: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
- `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
- `migration`: A fully automatic upgrade migration task with no engineer input required.
_Note: only one type should be chosen._
How are new versions calculated?
- ❗The `break` and `manual task` changelog types will result in a major release!
- 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
- ✨ All others will result in a minor version release.
Before this PR
A project internally was running out of heap in CI. We did a JFR and determined that
JarFile
and the sheer number ofInflaterInputStream
s it creates was using up gigabytes of space.DataInputStream
was also allocating a lot (it allocates 240+ bytes the moment you create it).After this PR
Use
JarInputStream
instead, which does not appear to have the same issue.==COMMIT_MSG== Reduce memory usage of
checkClasspathCompatible
==COMMIT_MSG==Possible downsides?