palantir / gradle-baseline

A set of Gradle plugins that configure default code quality tools for developers.
Apache License 2.0
299 stars 135 forks source link

Add gradle daemon target to BaselineJavaVersionsExtension #2802

Closed crogoz closed 3 months ago

crogoz commented 3 months ago

Before this PR

After this PR

Required for the Gradle Automanagement work. All the java versions requested by the BaselineJavaVersionsExtension and the BaselineJavaVersionExtension will be materialized as files inside the gradle/jdks/* directory. The gradle daemon version will be materialized in the filegradle/gradle-daemon-jdk-version. WIP PR here: https://github.com/palantir/gradle-jdks/compare/cr/patching2...cr/patchin2-generate-gradle?expand=1

==COMMIT_MSG== Add gradle daemon target to BaselineJavaVersionsExtension ==COMMIT_MSG==

Possible downsides?

changelog-app[bot] commented 3 months ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [x] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Add gradle daemon target to BaselineJavaVersionsExtension **Check the box to generate changelog(s)** - [x] Generate changelog entry