search

palantir / gradle-baseline

A set of Gradle plugins that configure default code quality tools for developers.
Apache License 2.0
299 stars 135 forks source link

Fix #2812 #2814

Open nakulj opened 3 months ago

nakulj commented 3 months ago

Before this PR

Tests miss the case when a method is called on the built string, see https://github.com/palantir/gradle-baseline/issues/2812

After this PR

Parens are now surround the append result, ensuring that the post-build method call is applied to the entire built string, not just the last element.

Possible downsides?

Adds parens even when unnecessary. These can be caught and fixed by UnnecessaryParentheses, but ideally they'd only be added if necessary.

palantirtech commented 3 months ago

Thanks for your interest in palantir/gradle-baseline, @nakulj! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

changelog-app[bot] commented 3 months ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [ ] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Add a test case to StringBuilderConstantParametersTests **Check the box to generate changelog(s)** - [ ] Generate changelog entry