On further inspection, it appears that accessing information about the MavenArtifacts for jars in the maven publishing extension requires forcing the javaCompiler property the compile task in Gradle 8.6+. Since we use info from MavenArtifact to configure the javaCompiler property (checking to see whether there are any jar artifacts), this makes an unresolvable circular evaluation.
After this PR
==COMMIT_MSG==
Prevent "Circular evaluation detected" error when using baseline-java-versions on Gradle 8.6+.
==COMMIT_MSG==
We avoid this by just not looking the published artifacts. Instead, we expand the list of known library and known distribution plugins and only check with them.
Possible downsides?
This may work less generally for non-palantir consumers of this plugin who do not use our distribution plugins. This plugin has always been focused on making it easy for Palantir consumers though.
The behaviour is now different. If someone was using non-standard plugins but depended on this plugin checking for jar non-artifacts to determine library status, it would now downgrade the java version they used to the libraryTarget, possibly causing errors.
What do the change types mean?
- `feature`: A new feature of the service.
- `improvement`: An incremental improvement in the functionality or operation of the service.
- `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
- `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
- `deprecation`: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
- `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
- `migration`: A fully automatic upgrade migration task with no engineer input required.
_Note: only one type should be chosen._
How are new versions calculated?
- ❗The `break` and `manual task` changelog types will result in a major release!
- 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
- ✨ All others will result in a minor version release.
Prevent "Circular evaluation detected" error when using baseline-java-versions on Gradle 8.6+.
**Check the box to generate changelog(s)**
- [x] Generate changelog entry
Before this PR
baseline-java-versions does not work in Gradle 8.6+. This error is produced:
On further inspection, it appears that accessing information about the
MavenArtifact
s for jars in the maven publishing extension requires forcing thejavaCompiler
property the compile task in Gradle 8.6+. Since we use info fromMavenArtifact
to configure thejavaCompiler
property (checking to see whether there are any jar artifacts), this makes an unresolvable circular evaluation.After this PR
==COMMIT_MSG== Prevent "Circular evaluation detected" error when using baseline-java-versions on Gradle 8.6+. ==COMMIT_MSG==
We avoid this by just not looking the published artifacts. Instead, we expand the list of known library and known distribution plugins and only check with them.
Possible downsides?