palantir / gradle-baseline

A set of Gradle plugins that configure default code quality tools for developers.
Apache License 2.0
299 stars 135 forks source link

Remove old pre Gradle 8.6 baseline-java-versions behaviour #2822

Closed CRogers closed 2 months ago

CRogers commented 2 months ago

Before this PR

In #2820, we changed the behaviour of baseline-java-versions, but only when Gradle >=8.6 was being used. Now we have upgraded a big chunk of repos to Gradle 8.7 and no issues have appeared.

After this PR

==COMMIT_MSG== Remove pre-Gradle 8.6 baseline-java-versions behaviour. ==COMMIT_MSG==

I'll probably wait a few more days just to check no one reports issues before merging. Wanted to make the PR ahead of time so we don't forget to delete the old behaviour.

Possible downsides?

changelog-app[bot] commented 2 months ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - πŸ› The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [ ] Improvement - [x] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Remove pre-Gradle 8.6 baseline-java-versions behaviour. **Check the box to generate changelog(s)** - [x] Generate changelog entry
felixdesouza commented 2 months ago

πŸ‘

CRogers commented 2 months ago

No one has complained so far!

svc-autorelease commented 2 months ago

Released 5.60.0