search

palantir / gradle-baseline

A set of Gradle plugins that configure default code quality tools for developers.
Apache License 2.0
299 stars 135 forks source link

Bump spotless and versionlock #2829

Closed daberkow closed 3 weeks ago

daberkow commented 1 month ago

Before this PR

Issues arose running spotless checks, as shown in #2828

After this PR

==COMMIT_MSG== Update spotless java to 6.25.0 from 6.6.0 ==COMMIT_MSG==

Possible downsides?

It was noted that updates to spotless "Newer spotless versions have issues resolving dependencies at configuration time", but the build seems to be working.

changelog-app[bot] commented 1 month ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [ ] Improvement - [x] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Update spotless java to 6.24.0 from 6.6.0 **Check the box to generate changelog(s)** - [x] Generate changelog entry
daberkow commented 1 month ago

This has been tested locally against a repo showing the issue, and bumping did correct the issue. I realized 6.25.0 is out, and will bump again.

daberkow commented 1 month ago

I am doing some checks, 6.25.0 is passing in circle but failing on my local system. 6.24.0 is passing in both. Trying to figure out why.

daberkow commented 3 weeks ago

https://github.com/palantir/gradle-baseline/pull/2313 https://github.com/diffplug/spotless/issues/1380 With gradle-consistent-versions this will cause a full build failure.

Pointed out, for anyone who has issues, you can add the newer spotless version to your classpath to override what is given here, and work from there.