search

palantir / gradle-baseline

A set of Gradle plugins that configure default code quality tools for developers.
Apache License 2.0
300 stars 135 forks source link

Configurable error-prone checks #626

Open schlosna opened 5 years ago

schlosna commented 5 years ago

What happened?

Configuring additional error-prone checks to ERROR (or WARNING) requires some repetitive code in each project that wants to promote additional checks.

See https://github.com/palantir/tritium/pull/254 and specifically https://github.com/palantir/tritium/pull/254/files#diff-c197962302397baf3a4cc36463dce5eaR75

What did you want to happen?

Allow streamlined method for promoting set of error-prone checks to ERROR, e.g. promoting all optional warnings and some experimental checks.

https://github.com/google/error-prone/blob/3d225c1eec6d8dada11730c9e9199b710ea26495/core/src/main/java/com/google/errorprone/scanner/BuiltInCheckerSuppliers.java#L593

schlosna commented 5 years ago

@uschi2000 for SA

uschi2000 commented 5 years ago

Can you start a thread on our internal mailing list before we move forward with this, @schlosna ?

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not been touched in the last 60 days. Please comment if you'd like to keep it open, otherwise it'll be closed in 7 days time.

schlosna commented 3 years ago

@j-baker enabling something like this on atlasdb would have flagged https://github.com/palantir/atlasdb/pull/5039